feat: add a Vc SoA implementation for transform3 #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niermann999
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
beomki-yeo
reviewed
Sep 15, 2023
|
And I suggest separating a PR for benchmark |
niermann999
force-pushed
the
feat-vectorized-transf
branch
from
05ebfae
to
8966ee3
Compare
The benchmarks are already part of #95 which this one is based on |
niermann999
force-pushed
the
feat-vectorized-transf
branch
4 times, most recently
from
d453d00
to
5b0bd48
Compare
niermann999
force-pushed
the
feat-vectorized-transf
branch
5 times, most recently
from
3aaabb0
to
244bb86
Compare
niermann999
force-pushed
the
feat-vectorized-transf
branch
3 times, most recently
from
21af1f6
to
940f03d
Compare
krasznaa
requested changes
Apr 22, 2024
niermann999
force-pushed
the
feat-vectorized-transf
branch
3 times, most recently
from
e71e259
to
bf84c78
Compare
…bra plugin and adds the transform3 implementation, including a test and benchmarks. Like the current vc_vc plugin, it uses the vector3 type as column vectors in the 4x4 matrix type that is used by the transform3. Elements that are known to be equal to zero or one are optimized away in the inversion and determinant calculations.
krasznaa
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on the previous development for an SoA Vc-based algebra plugin and adds the
transform3implementation, including a test and benchmarks. Like the currentvc_vcplugin, it uses thevector3type as column vectors in the 4x4 matrix type that is used by thetransform3. Elements that are known to be equal to zero or one are optimized away in the inversion and determinant calculations.