Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Classify Consent Clicks under consent checkpoint #351

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

trieloff
Copy link
Contributor

@trieloff trieloff commented Jul 5, 2024

  • feat(consent): new classifier for consent clicks
  • feat(google): log reclassified consent to google
  • feat(s3): log reclassified consent to s3

Clicks on consent dialogs are an important interaction to understand (especially in
the light of low rates of opt-in), so we track them under the consent checkpoint
if possible. This means the signal ratio for the click checkpoint will be higher
as only clicks on the actual page will be considered

@bosschaert
Copy link
Collaborator

bosschaert commented Jul 5, 2024

I noticed that the new classifyConsent(cssSelector) function is marked as uncovered:

src/consent.mjs | 72.92 | 100.00 | 0.00 | 36-48

If I run the tests locally with npm t I see a lot of these messages:

classifyConsent
  ﹣ should find onetrust (accept) in #onetrust-accept-btn-handler (0.332292ms) # test name does not match pattern
  ﹣ should find onetrust (reject) in #onetrust-reject-all-handler (0.045709ms) # test name does not match pattern
...

Seems like --test-name-pattern=Test in https://github.com/adobe/helix-rum-collector/blob/main/package.json#L11 skips them and many others.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants