Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: LCP source can be null #220

Merged
merged 1 commit into from
Jul 3, 2024
Merged

fix: LCP source can be null #220

merged 1 commit into from
Jul 3, 2024

Conversation

kptdobe
Copy link
Contributor

@kptdobe kptdobe commented Jul 2, 2024

I can see null source in the data. Applying the same to target to be sure.

@kptdobe kptdobe requested review from chicharr, ekremney and trieloff and removed request for ekremney July 2, 2024 11:58
Copy link

codecov bot commented Jul 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36.90%. Comparing base (6552ddc) to head (8b9f125).

Files Patch % Lines
src/index.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              1.x     #220   +/-   ##
=======================================
  Coverage   36.90%   36.90%           
=======================================
  Files           1        1           
  Lines         271      271           
=======================================
  Hits          100      100           
  Misses        171      171           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kptdobe kptdobe merged commit 4fe7ec4 into 1.x Jul 3, 2024
6 of 7 checks passed
@kptdobe kptdobe deleted the null-lcp-source branch July 3, 2024 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants