fix: return 204 No Content from /metrics endpoint

* Change status code to NO_CONTENT * Adjust integration tests
aerogear-attic · Mar 8, 2018 · 829427d · 829427d
1 parent 5d42dc4
commit 829427d
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/pkg/web/metricsHandler.go b/pkg/web/metricsHandler.go
@@ -45,5 +45,5 @@ func (mh *metricsHandler) CreateMetric(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	w.WriteHeader(200)
+	w.WriteHeader(204)
 }
diff --git a/pkg/web/metricsHandler_test.go b/pkg/web/metricsHandler_test.go
@@ -64,7 +64,7 @@ func TestMetricsEndpointShouldPassReceivedDataToMetricsService(t *testing.T) {
 	defer res.Body.Close()
 	_, err = ioutil.ReadAll(res.Body)
 
-	assert.Equal(t, 200, res.StatusCode)
+	assert.Equal(t, 204, res.StatusCode)
 
 	mockMetricsService.AssertExpectations(t)
 }