feat: update safari iOS readme #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciscoafonsoo
had a problem deploying
to
Staging
GitHub Actions
Failure
|
Antes de mais, obrigado pela sugestão! |
afonsosousah
reviewed
May 5, 2024
Update safari iOS readme with details in case the location services are not enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello hello,
First of all, thanks for this app, the effort is really appreciated !
I'm opening this Pull Request in order to contribute to improve the instructions on how to run this on Sarafi iOS. I ran into a problem where the location was not working and it never popped any option. Even when going to the website settings and enabling location directly.
I figured out that the location services for safari websites need to be enabled and iOS will not prompt you for this. This took a long time to figure out, so I wanted to make a change in the readme to make it more clear.
If you want me to follow any standard in terms of branches, versioning or commit naming conventions let me know