Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add process initializer (from Python 3.7) to complete issue 21423 implementation #94

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fahhem
Copy link
Contributor

@fahhem fahhem commented Jan 3, 2020

Also updates the docs for thread and process pools.

Unfortunately, the ProcessPoolExecutor is vastly differently implemented than upstream Python 3, so I couldn't use stick to the upstream PR as much as for thread pools: https://github.com/python/cpython/pull/4241/files

Is there any interest in wholesale copying the Python 3.7 process pool executor instead of redoing the bpo's out of order?

@s0undt3ch
Copy link

After merge what would be the expected time frame to release it?

@agronholm
Copy link
Owner

Also updates the docs for thread and process pools.

But, there should also be new tests. Surely Python 3 had some added when this feature was introduced?

Is there any interest in wholesale copying the Python 3.7 process pool executor instead of redoing the bpo's out of order?

IIRC the new process pool executor relies on Python 3 features. Otherwise would've been nice because process pools are broken beyond repair on Python 2.

After merge what would be the expected time frame to release it?

Within a day or two. It should be noted that since Python 2 has now reached its End Of Life, I will not be adding any more features to this library beyond this one. If somebody else wants to take over, that is negotiable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants