Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Add a filesystem-based backend for artifact storage #3156

Closed
wants to merge 3 commits into from

Conversation

gpascale
Copy link

@gpascale gpascale commented Jun 4, 2024

Adds FilesystemArtifactStorage, a local filesystem-backed implementation of AbstractArtifactStorage, and adds it to the registry.

Works very similarly to S3ArtifactStorage, except you would pass a url like file:///path/to/artifacts as the uri.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@gpascale gpascale changed the title add filesystem_storage, a filesystem-based backend for artifact storage [feat] add a filesystem-based backend for artifact storage Jun 4, 2024
@gpascale
Copy link
Author

gpascale commented Jun 4, 2024

I was interested in this, and saw a few issues (#3144, #3139) mentioning it as well, so I thought I'd see if I could implement it. It seems to be working in my very simple setup, but I haven't done that much testing.

Curious for feedback from maintainers as to whether this looks like the correct approach or not.

Copy link
Member

@alberttorosyan alberttorosyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gpascale the changes look good! I've tested them and found no issues.
Would you mind updating the CHANGELOG.md file to reflect the changes and sign the CLA agreement?
We can proceed with the merge right after that

@alberttorosyan alberttorosyan changed the title [feat] add a filesystem-based backend for artifact storage [feat] Add a filesystem-based backend for artifact storage Jun 11, 2024
@alberttorosyan alberttorosyan marked this pull request as ready for review June 11, 2024 07:26
@alberttorosyan
Copy link
Member

@gpascale I've pushed changes in CHANGELOG.md. Please complete the CLA so we can proceed with merge.

@alberttorosyan
Copy link
Member

@gpascale closing this PR as the CLA is a mandatory step. Will commit changes on your behalf in #3164

@gpascale
Copy link
Author

gpascale commented Jun 17, 2024

@alberttorosyan Ah sorry for going dark on this. I was travelling the past few weeks and not checking things. Glad to heard you've gotten the feature in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants