Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross out files with checked viewed box #58

Merged
merged 3 commits into from
May 25, 2020

Conversation

mvanbommel
Copy link
Contributor

Added strike through for the file names in explorer whose viewed boxes have been checked, as referenced in #26.

I am really enjoying the extension but I was missing this feature, so I figured I would see if I could add it myself, and I think I've got the functionality figured out. I've only recently started getting my feet wet with JavaScript, and this is my first time working on an extension, so certainly open to any and all feedback.

Copy link
Owner

@alexmdodge alexmdodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great Matt, thanks! I'll test it out over the weekend and we can probably merge and release this next week!

Copy link
Owner

@alexmdodge alexmdodge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍 Merging this for testing, I'll continue to perform integration testing this week and get a release out when possible. Thanks for the contribution!

@alexmdodge alexmdodge merged commit ee4fc40 into alexmdodge:develop May 25, 2020
@mvanbommel mvanbommel deleted the cross-out-file-when-viewed branch May 25, 2020 18:13
@alexmdodge
Copy link
Owner

@mvanbommel This feature was included in the 1.2.0 release! Just waiting on Google to approve the new extension version.

@alexmdodge
Copy link
Owner

@mvanbommel Alright managed to fix up some requirements from Google, but this is out in the Chrome store now under 1.2.1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants