Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix setting up callback #378

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix setting up callback #378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions allenact/algorithms/onpolicy_sync/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,17 +240,17 @@ def setup_callback_classes(self, callbacks: Optional[str]) -> Set[Callback]:
callback_classes = [
mod_class[1]
for mod_class in classes
if issubclass(mod_class[1], Callback)
if issubclass(mod_class[1], Callback) and mod_class[1] != Callback
]

assert callback_classes == 1, (
assert len(callback_classes) == 1, (
f"Expected a single callback class in {filename}, but found {len(callback_classes)}."
f" These classes were found: {callback_classes}."
)

for mod_class in callback_classes:
# NOTE: initialize the callback class
callback = mod_class[1]()
callback = mod_class()
callback.setup(**setup_dict)
callback_objects.add(callback)

Expand Down
Loading