-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add prague engine types #557
Conversation
Co-authored-by: DaniPopes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just nits
/// Deposit signature | ||
pub signature: FixedBytes<96>, | ||
/// Deposit index | ||
#[serde(with = "alloy_serde::u64_hex")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i assume these are exit sig/exit index?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
honestly no idea
index field
The index field may appear unnecessary but it is important information for deposit processing flow on the Consensus Layer.
not very helpful -.-
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where do you see this? i don't see the comment in https://github.com/ethereum/execution-apis/blob/main/src/engine/prague.md#exitv1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in fact, a lot of the fields are not present in that doc.. is it out of date?
Co-authored-by: Oliver Nordbjerg <[email protected]>
Co-authored-by: Oliver Nordbjerg <[email protected]>
* feat: add prague engine types * Update crates/eips/src/eip6110.rs Co-authored-by: DaniPopes <[email protected]> * clippy * Update crates/eips/src/eip6110.rs Co-authored-by: Oliver Nordbjerg <[email protected]> * Update crates/rpc-types-engine/src/exit.rs Co-authored-by: Oliver Nordbjerg <[email protected]> --------- Co-authored-by: DaniPopes <[email protected]> Co-authored-by: Oliver Nordbjerg <[email protected]>
* Move BlockId type to alloy-eip * suggested changes * touchups * chore: touchups * fix: tmp fix for PendingTransactionBuilder::get_receipt (#558) * feat: add prague engine types (#557) * feat: add prague engine types * Update crates/eips/src/eip6110.rs Co-authored-by: DaniPopes <[email protected]> * clippy * Update crates/eips/src/eip6110.rs Co-authored-by: Oliver Nordbjerg <[email protected]> * Update crates/rpc-types-engine/src/exit.rs Co-authored-by: Oliver Nordbjerg <[email protected]> --------- Co-authored-by: DaniPopes <[email protected]> Co-authored-by: Oliver Nordbjerg <[email protected]> * fix: add more generics to any and receipt with bloom (#559) * fix: signer fills from if unset (#555) * fix: override txtype during submission prep (#556) * Use the same way to both serialize and deserialize `OptimismPayloadAttributes::gas_limit`. (#563) * Use the same way to both serialize and deserialize `OptimismPayloadAttributes::gas_limit`. I understand that `op-reth` only ever deserializes this structure. My use case is to serialize this struct and pass it to `op-geth`. The latter expects it to be hex. * rustfmt --------- Co-authored-by: Matthias Seitz <[email protected]> * feat: add ClientVersionV1 (#562) * added ClientVersionV1 * touchups * rustfmt --------- Co-authored-by: Matthias Seitz <[email protected]> * clippy * use alloc --------- Co-authored-by: Matthias Seitz <[email protected]> Co-authored-by: Arsenii Kulikov <[email protected]> Co-authored-by: DaniPopes <[email protected]> Co-authored-by: Oliver Nordbjerg <[email protected]> Co-authored-by: James Prestwich <[email protected]> Co-authored-by: Raman Hafiyatulin <[email protected]> Co-authored-by: guha-rahul <[email protected]>
adds payload v4 type for https://github.com/ethereum/execution-apis/blob/main/src/engine/prague.md#depositreceiptv1
also adds https://eips.ethereum.org/EIPS/eip-6110 Deposit type
This does not yet enable V4 as supported variant to the payload enum, this will follow once reth is ready for this
ref paradigmxyz/reth#7363