Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Node-4.2.x #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update for Node-4.2.x #5

wants to merge 1 commit into from

Conversation

mojodna
Copy link
Contributor

@mojodna mojodna commented Dec 22, 2015

Primarily for compatibility with jest (used by npm test).

With node-0.12.7, jest does this:

$ npm test

> @panorama/[email protected] test /Users/seth/src/americanpanorama/panorama
> jest

/Users/seth/src/americanpanorama/panorama/node_modules/jest-cli/src/TestRunner.js:433
        const cacheA = testPerformanceCache && testPerformanceCache[a[0]];
        ^^^^^
SyntaxError: Use of const in strict mode.
    at exports.runInThisContext (vm.js:73:16)
    at Module._compile (module.js:443:25)
    at Object.Module._extensions..js (module.js:478:10)
    at Module.load (module.js:355:32)
    at Function.Module._load (module.js:310:12)
    at Module.require (module.js:365:17)
    at require (module.js:384:17)
    at Object.<anonymous> (/Users/seth/src/americanpanorama/panorama/node_modules/jest-cli/src/jest.js:13:18)
    at Module._compile (module.js:460:26)
    at Object.Module._extensions..js (module.js:478:10)
npm ERR! Test failed.  See above for more details.

Primarily for compatibility with jest (used by `npm test`).
@mojodna
Copy link
Contributor Author

mojodna commented Dec 22, 2015

Why 4.2? It's an LTS release and we don't need functionality introduced since then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant