Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep lodash out of the resulting bundle #6

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mojodna
Copy link
Contributor

@mojodna mojodna commented Dec 22, 2015

Matching import/requires of nested resources might have worked, but this makes the use of lodash components more explicit.

I saw this so I fixed it:

/*
  TODO: Keep `lodash` out of bundle
  Tried adding the below to externals but didn't work.
    'lodash': {
      commonjs: 'lodash',
      commonjs2: 'lodash',
      amd: '_',
      root: '_'
    }
*/

Matching import/requires of nested resources might have worked, but this
makes the use of lodash components more explicit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant