Fix TUI channel panics #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
amazing, thanks @devyn, that solves my part of #55 🥳 @WindSoilder, could you try and see if that's any better on your side? 😇 because we are so close to the release, i'll wait a bit and bump to 0.93.0 when it's there so that dependencies are clean and stable again 🙏 |
|
Thanks! I've played with it, and it works fine to me |
|
there it is, all working 😌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix panics when sending to the TUI channel.
Because failing to send just means the other end hung up, we don't really need to do anything special. It's totally expected that the other side will hang up eventually. It's best for us to just break out of the loop.
This also updates nushell to a revision I have right now that fixes local socket, but this should probably be changed on release.