[Crane] Replacing AnimatedContent with Pager, and LazyGrid with LazyStaggeredGrid #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Crane/gradle/libs.versions.toml
riggaroo
changed the title
Crane/app/src/main/java/androidx/compose/samples/crane/base/ExploreSection.kt
Outdated
Show resolved
Hide resolved
Crane/app/src/main/java/androidx/compose/samples/crane/base/ExploreSection.kt
Show resolved
Hide resolved
JolandaVerhoef
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing
AnimatedContentwithHorizontalPager. There is nothing incorrect about usingAnimatedContent, the contents of my earlier blog post are still valid. However, in this use case, aPageris more correct for the UX of this screen, users expect to be able to swipe between tabs.Pager.mp4
Replacing
LazyGridwithLazyStaggeredGrid