Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reply] Allow multi-select of emails and highlight the opened email #1123

Merged
merged 3 commits into from
May 9, 2023

Conversation

JolandaVerhoef
Copy link
Contributor

Allow multi-select of emails, by:

  • tapping the avatar
  • long-pressing the card

A selected email (during multi-select) is highlighted with a different background and a checkmark instead of the Avatar. The opened email is highlighted with a different container color.

This PR also fixes issue #1122 (ripple not clipped)

Screenshot_20230430_135836

Change-Id: Ie977a1d1245f2c41a5f13755f54d7571814a323a
@JolandaVerhoef JolandaVerhoef requested a review from a team as a code owner April 30, 2023 17:59
@JolandaVerhoef JolandaVerhoef changed the title Allow multi-select of emails and highlight the opened email [Reply] Allow multi-select of emails and highlight the opened email Apr 30, 2023
Change-Id: I8d32e6fb3fbeb501e3e9eba116b0f6056df22e93
@JolandaVerhoef JolandaVerhoef requested review from riggaroo and removed request for mlykotom May 2, 2023 18:00
Change-Id: I0fcf9b5b2a25464cb38f4b4c9f53ffe1c8ab16e3
Copy link
Contributor

@Gurupreet Gurupreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! this is a great addition.

Copy link
Contributor

@astamato astamato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@JolandaVerhoef JolandaVerhoef merged commit 4d48775 into main May 9, 2023
6 checks passed
@JolandaVerhoef JolandaVerhoef deleted the jv/reply-multi-select branch May 9, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants