Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimmer 10, Scenes #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Dimmer 10, Scenes #10

wants to merge 2 commits into from

Conversation

dendeps
Copy link

@dendeps dendeps commented Oct 19, 2017

  1. Created MHDimmer10 object to support 10-level dimmers like F418, 002622.
  2. Updated OnDimmer function to update brightness level in app when receive feedback(if someone press switch button).
  3. Created MHScene object to activate scenarios stored in scenario modules F420 (haven't fully tested yet).

Sorry if I'm doing something not correctly, using Github for a first time :)

Copy link
Owner

@angeloxx angeloxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please split the commit in two different:

  • one for MHScene
  • one for MHDimmer10 and use dimmerLevels to convert 10-level to level

@dendeps
Copy link
Author

dendeps commented Oct 22, 2017

Hi, I'll review what you requested.

As for dimmer level, it's linear, as you can see here:
file

screen shot 2017-10-22 at 10 39 38 pm

@angeloxx
Copy link
Owner

I'm sorry, is not linear; the documentation is not true, the correct levels is reported in "dimmerLevels" array and this info comes from Legrand (I worked for Legrand group in a Openwebnet related project) and you can double check this information using a 100-level dimmer as a 10-level.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants