-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add rough form for IBC withdrawals #1133
Conversation
As a side note. I've just added tx_ibc checksums to the indexer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not test it until the end because of the "Per-epoch throughput limit", but I'm pretty sure it works fine. I also got an error when channel became inactive so I think all is good 👍
import { getFirstError } from "atoms/utils"; | ||
|
||
const keplr = (window as KeplrWindow).keplr!; | ||
const namada = (window as WindowWithNamada).namada!; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For testing I had to move this inside submitIbcTransfer
otherwise it was sometimes undefined :P
0a06239
to
8b825f3
Compare
channelId: channel, | ||
timeoutHeight: undefined, | ||
timeoutSecOffset: undefined, | ||
memo: `Namada->${keplrChain}`, // how is this different from the wrapper memo? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The wrapper memo in this case will be applied with the Tx on Namada, but the IBC Transfer memo gets passed on via the IBC Msg sent to destination, AFAIK. I think in this case, we could omit the wrapper memo if you like. It is kind of weird that we have memos at different levels, the Tx wrapper args, then individual commitments all have their own memo, but in this case, the IbcTransfer memo would be useful to see on Keplr!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see! I've just gone ahead and removed the memos for now, since they're not used yet, but I can add them in again later.
ccecee4
to
cc82853
Compare
cc82853
to
623b4ed
Compare
This PR adds another very rough IBC prototype, this time for IBC transfers from Namada to Cosmos.
Note: The tx details are not dislaying properly in the extension, but as far as I know we need to get the IBC WASM hash from the indexer to do this, which it is currently not sending. anoma/namada-indexer#120
Testing
theta-testnet-001
as the Cosmos testnet)gaiad query bank balances <cosmos address> --node https://rpc-t.cosmos.nodestake.top/