Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: shield nam #1165

Open
wants to merge 8 commits into
base: feat/masp-multicore-indexer-integration-with-multicore
Choose a base branch
from
Open

feat: shield nam #1165

wants to merge 8 commits into from

Conversation

mateuszjasiuk
Copy link
Collaborator

@mateuszjasiuk mateuszjasiuk commented Oct 7, 2024 •
edited
Loading

Changes

  • added shielding web worker with comlink
  • changed shielded sync worker to use comlink
  • moved some code unrelated to hooks out of hooks to fix dependencies issues in web workers
  • moved big numbers fix to utils
  • some smaller refactors so we can reuse code in webworkers
  • this WorkerTest thingy is added just for testing so it's a bit garbage, I will remove it before merge

What's missing

  • toasts
  • tx details in approval screen - we can do it in the next PR

How to test

  • add <WorkerTest /> in the App.tsx of namadillo
  • run
// To test shielding
await window.buildShieldlingTx("znam...", 100)
// To retest shielded sync
await window.shieldedSync("zvknam1...");

@mateuszjasiuk mateuszjasiuk force-pushed the feat/shield-nam branch 2 times, most recently from c5b8b17 to f296f80 Compare October 8, 2024 14:03
@mateuszjasiuk mateuszjasiuk requested review from pedrorezende, jurevans, emccorson and euharrison and removed request for jurevans October 8, 2024 15:28
@mateuszjasiuk mateuszjasiuk marked this pull request as ready for review October 8, 2024 15:28
jurevans
jurevans reviewed Oct 8, 2024
View reviewed changes
apps/namadillo/src/App/WorkerTest.tsx
},
});

const shiedlingMsgValue = new ShieldingTransferMsgValue({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: Type: shiedlingMsgValue -> shieldingMsgValue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jurevans jurevans jurevans left review comments

@pedrorezende pedrorezende Awaiting requested review from pedrorezende

@emccorson emccorson Awaiting requested review from emccorson

@euharrison euharrison Awaiting requested review from euharrison

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mateuszjasiuk @jurevans