Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run files through ansible-lint #184

Merged
merged 13 commits into from
Jan 18, 2024
Merged

run files through ansible-lint #184

merged 13 commits into from
Jan 18, 2024

Conversation

rndmh3ro
Copy link
Collaborator

@rndmh3ro rndmh3ro marked this pull request as draft January 16, 2024 09:14
@rndmh3ro rndmh3ro marked this pull request as ready for review January 16, 2024 09:53
Copy link
Collaborator

@beechesII beechesII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for PR. I added serveral comments.

meta/main.yml Outdated Show resolved Hide resolved
meta/main.yml Outdated Show resolved Hide resolved
examples/site.yml Outdated Show resolved Hide resolved
tasks/cni.yml Show resolved Hide resolved
tasks/docker.yml Show resolved Hide resolved
tasks/get_gossip_key.yml Show resolved Hide resolved
tasks/get_gossip_key.yml Show resolved Hide resolved
tasks/install.yml Show resolved Hide resolved
tasks/install.yml Show resolved Hide resolved
tasks/install_podman.yml Show resolved Hide resolved
Co-authored-by: Christopher Grau <[email protected]>
Copy link
Collaborator

@beechesII beechesII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rndmh3ro rndmh3ro merged commit 3050474 into master Jan 18, 2024
14 checks passed
@rndmh3ro rndmh3ro deleted the linting branch January 18, 2024 13:23
Rendanic pushed a commit to opitzconsulting/ansible-nomad that referenced this pull request Apr 3, 2024
* run files through ansible-lint

* Fix linting for example

* Capitalize handlers

* add missing dashes to reqs-file

* min_ansible_version should be a string

* fix cut parameter

* remove non-existing parameter in example

* use command instead of shell

* release versions in meta are strings

* fix command task

* fix typo

* Apply suggestions from code review

Co-authored-by: Christopher Grau <[email protected]>

---------

Co-authored-by: Christopher Grau <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants