Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nomad 1.7.x compatibility issue #190

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

sas1024
Copy link
Contributor

@sas1024 sas1024 commented Feb 21, 2024

Fix for #179 issue

@stoneus
Copy link

stoneus commented Feb 21, 2024

Perfect!

@madsboddum
Copy link

Looks good to me.

@rndmh3ro
Copy link
Collaborator

Does this still work with versions older than 1.7?

@sas1024
Copy link
Contributor Author

sas1024 commented Feb 21, 2024

@rndmh3ro yes, it works with all Nomad versions above 0.8.x

@rndmh3ro
Copy link
Collaborator

Thanks, just tested it myself:

cat /tmp/test-nomad.yml
data_dir  = "/var/lib/nomad"

bind_addr = "0.0.0.0" # the default

advertise {
  # Defaults to the first private IP address.
  http = "1.2.3.4"
  rpc  = "1.2.3.4"
  serf = "1.2.3.4:5648" # non-default ports may be specified
}

server {
  enabled          = true
  bootstrap_expect = 3
}

client {
  enabled       = true
}

plugin "raw_exec" {
  config {
    enabled = true
  }
}

consul {
  address = "1.2.3.4:8500"
  tags = []
}

segu:[~/dev/tmp]:
> ./nomad -version
Nomad v1.5.0
BuildDate 2023-03-01T10:11:42Z
Revision fc40c491cacec3d8ec3f2f98cd82b9068a50797c
segu:[~/dev/tmp]:
> ./nomad config validate /tmp/test-nomad.yml
Configuration is valid!
segu:[~/dev/tmp]:
> nomad -version
Nomad v1.7.5
BuildDate 2024-02-13T15:10:13Z
Revision 5f5d4646198d09b8f4f6cb90fb5d50b53fa328b8
segu:[~/dev/tmp]:
> nomad config validate /tmp/test-nomad.yml
WARNING: mTLS is not configured - Nomad is not secure without mTLS!
Configuration is valid!

@rndmh3ro rndmh3ro added the bug label Feb 22, 2024
@rndmh3ro rndmh3ro merged commit aecfeca into ansible-community:master Feb 22, 2024
14 checks passed
Rendanic pushed a commit to opitzconsulting/ansible-nomad that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants