-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(k8s): watch_endpoint_slices_schema should be watch_endpoint_slices #11000
base: master
Are you sure you want to change the base?
Conversation
config watch_endpoint_slices not watch_endpoint_slices_schema
Can we add test cases to cover this? |
@paradin are you still available to work on this? |
@@ -431,7 +431,7 @@ local function single_mode_init(conf) | |||
|
|||
local default_weight = conf.default_weight | |||
local endpoints_informer, err | |||
if conf.watch_endpoint_slices_schema then | |||
if conf.watch_endpoint_slices then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if conf.watch_endpoint_slices then | |
if conf.watch_endpoint_slices then |
I don't understand why would you need that? What is the problem it is trying to solve here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no issue linked to this PR and IMO it's not solving any problem so far. I'm not sure why would you want to change the name? Can you help me here?
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the [email protected] list. Thank you for your contributions. |
config watch_endpoint_slices not watch_endpoint_slices_schema
Description
Fixes # (issue)
Checklist