Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MATH-1579: created new clustering module #234

Closed
wants to merge 12 commits into from
Closed

MATH-1579: created new clustering module #234

wants to merge 12 commits into from

Conversation

orionlibs
Copy link

@orionlibs orionlibs commented Jul 18, 2023

MATH-1579 initial commit for modularising the legacy clustering package. Created new clustering module and moved several classes from legacy into it. These classes do not dependent on any library. Dependencies will be added in later commits or PRs as legacy exceptions, statistics, linear algebra and distance classes start moving to the appropriate modules

@orionlibs orionlibs changed the title MATH: created new clustering module and moved several classes from le… MATH: created new clustering module Jul 18, 2023
@orionlibs orionlibs changed the title MATH: created new clustering module MATH-1579: created new clustering module Jul 18, 2023
@orionlibs
Copy link
Author

The build failed because i declared in the pom.xml the artifact commons-math-clustering which doesn't exist yet in the repo. I didn't think of that. What do I have to do about it?

@orionlibs
Copy link
Author

Removed unused dependency

@aherbert
Copy link
Contributor

You should add commons-math-clustering to the top level pom.xml so it is included in the build reactor, then add it as a dependency to the commons-math-legacy module so this module can see the classes that you have moved.

@orionlibs
Copy link
Author

@aherbert fixed

@orionlibs
Copy link
Author

fixed checkstyle errors

@orionlibs orionlibs closed this Dec 3, 2023
@orionlibs orionlibs deleted the MATH-refactor-clustering-package branch December 4, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants