[DO-NOT-MERGE] Enable new parser test for CI check in relation to incubator-kie-drools/pull/5989 #5990

@disabled

apache#5682) * add antlr4 based drl parser * bump to drools 8.16.0.Beta * improve node position discovery * first c3 integration * Module reorganization (#2) * WIP * Ignore directories * Add debug. Minor modifications * WIP * Fix tests - add comments * manage null ast nodes and fix failing test * improve drl parser * Fix basic completion (#4) * Add Java grammar, fix DRL grammar, simplify token index calculation, remove template code * Add ignored tokens to completion Co-authored-by: livio <[email protected]> * add constraints parsing * - Added DRLParserWrapper to store errors using DRLErrorListener (#5) - Added MiscDRLParserTest which is being ported from RuleParserTest to enhance coverage. * Enhance test/grammar coverage. function import, global, exists, not (#6) * Enhance test/grammar coverage. and, or, listExpression (#7) * Enhance test/grammar coverage. matches, single quoted string, escape (#9) - Introduced drlExpression, drlPrimary, drlLiteral, DRL_STRING_LITERAL * Enhance test/grammar coverage. dialect, invalid lhs (apache#10) * Enhance test/grammar coverage. keyword collision (apache#11) - Add "DRL_" prefix for DRL keywords for clarification * Enhance test/grammar coverage. function, attributes, consequence (apache#12) * Enhance test/grammar coverage. function, attributes, consequence - better getText preserving whitespaces - resolving WARNs because of overlapping keywords * - No need to declare duplicate keywords * Enhance test/grammar coverage. OR, inline map (apache#13) * OpenRewrite applied for junit5 and assertj (apache#14) * Enhance test/grammar coverage. label, consequenceLocation, test refac… (apache#15) * Enhance test/grammar coverage. label, consequenceLocation, test refactoring, assertj best practice * - better test method names * [DROOLS-7253] Review and improve drools-lsp parser Visitor design (apache#16) * [DROOLS-7253] Review and improve drools-lsp parser Visitor design - Remove currentConstructStack. Utilize return object instead. * - Remove instance fields. Utilize return objects instead. * [DROOLS-7270] Enhance test/grammar coverage : andRestriction, orRestriction (#4) - Removed some unused cast * [DROOLS-7271] Fully port RuleParserTest as MiscDRLParserTest with @disabled and priority comment (apache#10) * [DROOLS-7285] Failed to parse and/or with parentheses in LHS (apache#15) * [DROOLS-7286] Failed to parse binding with || (apache#21) * [DROOLS-7287] Failed to parse comments in RHS (apache#23) * [DROOLS-7287] Failed to parse comments in RHS * - add rhs string check * [DROOLS-7515] Parser : Accept plain text in RHS (apache#26) * [DROOLS-7515] Parser : Accept plain text in RHS * - Handle keyword token in RHS * - Removed sysout * - Revert statementKeywords. Instead, define DRL_END with newline or EOF * - fix method name * [DROOLS-7288] Failed to parse complex parentheses (apache#27) * [DROOLS-7288] Failed to parse complex parentheses - bump to 8.43.0.Final * additional tests * [DROOLS-7289] Implement accumulate (apache#28) * [DROOLS-7296] Implement from entry-point (apache#30) * [DROOLS-7297] Implement import accumulate (apache#29) * [DROOLS-7290] Implement BigInteger literal, BigDecimal literal (apache#31) * [DROOLS-7292] Implement eval (apache#32) * [DROOLS-7293] Implement extends (apache#33) * [DROOLS-7294] Implement forall (apache#34) * [DROOLS-7298] Implement memberOf (apache#35) * [DROOLS-7300] Implement positional constraint (apache#36) * [DROOLS-7304] Implement temporal operators (apache#38) - Also covers [DROOLS-7303] Implement sliding window * [DROOLS-7301] Implement query (apache#37) - Also partially fixes [DROOLS-7302] Implement semicolon delimiter * [DROOLS-7295] Implement from collect (apache#39) * [DROOLS-7305] Implement type declaration (apache#40) - also covers [DROOLS-7291] Implement entry-point declaration - also covers window declaration * [DROOLS-7306] Implement unification (apache#41) * [DROOLS-7306] Implement unification - Also [DROOLS-7307] Parse attribute agenda-group * [DROOLS-7308] Parse attribute without value - Also [DROOLS-7309] Parse attribute with parentheses * [DROOLS-7310] parse nested parentheses (apache#42) * [DROOLS-7310] parse nested parentheses * - Adding code commentes and explanations - Adding more nested level tests * [DROOLS-7577] drools-lsp : Add comments and explanations for drools-p… (apache#43) * [DROOLS-7577] drools-lsp : Add comments and explanations for drools-parser * removed syntax examples * [DROOLS-7591] Experiment branch : migrate a new drools-lsp parser into drools (apache#44) - Add some methods to call from drools code base * Move necessary files without any additional modifications * Update DRL6Expressions.g4 to ANTLR 4 (apache#47) * Add DescrDumperTest and fix the expression parser grammar (apache#48) * Add DescrDumperTest * Fix it * [DROOLS-7591] Experiment branch : migrate a new drools-lsp parser into drools - New parser is migrated in drools-drl/drools-drl-parser with org.drools.drl10.parser package - To enable the new parser, run `mvn test -PDRL10` - At the moment, we get lots of test failures especially in drools-model/drools-model-codegen and drools-test-coverage/test-compiler-integration * - License header - Revert an inappropriate test edit - Removed unnecessary profile - Clarify unsupported methods - Removed unnecessary bom dependency --------- Co-authored-by: mariofusco <[email protected]> Co-authored-by: Gabriele Cardosi <[email protected]> Co-authored-by: Livio Benčik <[email protected]> Co-authored-by: livio <[email protected]> Co-authored-by: Jiří Locker <[email protected]>

…rser int…" (apache#5689) This reverts commit 3699d67.

* WIP * Ignore directories * Add debug. Minor modifications * WIP * Fix tests - add comments

* Add Java grammar, fix DRL grammar, simplify token index calculation, remove template code * Add ignored tokens to completion Co-authored-by: livio <[email protected]>

- Added MiscDRLParserTest which is being ported from RuleParserTest to enhance coverage.

) - Introduced drlExpression, drlPrimary, drlLiteral, DRL_STRING_LITERAL

- Add "DRL_" prefix for DRL keywords for clarification

…che#12) * Enhance test/grammar coverage. function, attributes, consequence - better getText preserving whitespaces - resolving WARNs because of overlapping keywords * - No need to declare duplicate keywords

apache#15) * Enhance test/grammar coverage. label, consequenceLocation, test refactoring, assertj best practice * - better test method names

…ache#16) * [DROOLS-7253] Review and improve drools-lsp parser Visitor design - Remove currentConstructStack. Utilize return object instead. * - Remove instance fields. Utilize return objects instead.

…iction (#4) - Removed some unused cast

…sabled

…sabled and priority comment (apache#10)

* [DROOLS-7287] Failed to parse comments in RHS * - add rhs string check

* [DROOLS-7515] Parser : Accept plain text in RHS * - Handle keyword token in RHS * - Removed sysout * - Revert statementKeywords. Instead, define DRL_END with newline or EOF * - fix method name

* [DROOLS-7288] Failed to parse complex parentheses - bump to 8.43.0.Final * additional tests

…e#31)

- Also covers [DROOLS-7303] Implement sliding window

- Also partially fixes [DROOLS-7302] Implement semicolon delimiter

- also covers [DROOLS-7291] Implement entry-point declaration - also covers window declaration

* [DROOLS-7306] Implement unification - Also [DROOLS-7307] Parse attribute agenda-group * [DROOLS-7308] Parse attribute without value - Also [DROOLS-7309] Parse attribute with parentheses

* [DROOLS-7310] parse nested parentheses * - Adding code commentes and explanations - Adding more nested level tests

apache#43) * [DROOLS-7577] drools-lsp : Add comments and explanations for drools-parser * removed syntax examples

…o drools (apache#44) - Add some methods to call from drools code base

* Add DescrDumperTest * Fix it

…o drools - New parser is migrated in drools-drl/drools-drl-parser with org.drools.drl10.parser package - To enable the new parser, run `mvn test -PDRL10` - At the moment, we get lots of test failures especially in drools-model/drools-model-codegen and drools-test-coverage/test-compiler-integration

- Revert an inappropriate test edit - Removed unnecessary profile - Clarify unsupported methods - Removed unnecessary bom dependency

apache#5693) * [incubator-kie-drools#5681] Experiment: New DRL Parser : Test failure : Unknown language level - Revert the introduction of LanguageLevelOption.DRL10. Use DRL6 as usual. Instead, intorduced system property "drools.drl.antlr4.parser.enabled" for parser impl switch - Use a package name 'antlr4' instead of 'drl10' for the new parser separation * - Enable the new parser by default so that CI can run - Also suppress some GHAs which don't run with a feature branch

…ithout preceding white-space (apache#5698)

…ngs in RHS (apache#5726)

…g) is null (apache#5730)

* Add missing `@Test` annotation * Fix a typo in method name

apache#5751) * [incubator-kie-drools#5743] Update Developer_Notes.md to be community-friendly * Update drools-drl/drools-drl-parser/Developer_Notes.md Co-authored-by: Jiří Locker <[email protected]> * Update drools-drl/drools-drl-parser/Developer_Notes.md Co-authored-by: Jiří Locker <[email protected]> * - Add Design notes --------- Co-authored-by: Jiří Locker <[email protected]>

apache#5767) * [incubator-kie-drools#5705] [new-parser] no viable alternative after contains operator * - Add comment * Update drools-drl/drools-drl-parser-tests/src/test/java/org/drools/drl/parser/antlr4/MiscDRLParserTest.java Co-authored-by: Jiří Locker <[email protected]> * Update drools-drl/drools-drl-parser-tests/src/test/java/org/drools/drl/parser/antlr4/MiscDRLParserTest.java Co-authored-by: Jiří Locker <[email protected]> * Update drools-drl/drools-drl-parser-tests/src/test/java/org/drools/drl/parser/antlr4/MiscDRLParserTest.java Co-authored-by: Jiří Locker <[email protected]> * Update drools-drl/drools-drl-parser-tests/src/test/java/org/drools/drl/parser/antlr4/MiscDRLParserTest.java Co-authored-by: Jiří Locker <[email protected]> * - add javadoc to ParserHelper.isPluggableEvaluator --------- Co-authored-by: Jiří Locker <[email protected]>

…en (apache#5771)

…d name is a drl keyword (apache#5783)

As in `String(this == "x")`.

…en (apache#5790) * [incubator-kie-drools#5706] Grouped accessors for nested objects broken * Update drools-drl/drools-drl-parser/src/main/java/org/drools/drl/parser/antlr4/DRLVisitorImpl.java Co-authored-by: Jiří Locker <[email protected]> * Update drools-drl/drools-drl-parser-tests/src/test/java/org/drools/drl/parser/antlr4/MiscDRLParserTest.java Co-authored-by: Jiří Locker <[email protected]> --------- Co-authored-by: Jiří Locker <[email protected]>

…ltiKieBaseTest (apache#5794)

apache#5793) * [incubator-kie-drools#5708] [new-parser] function definition causes an error * - enhance getTextPreservingWhitespace to avoid string manipulation

* LHS patterns can have annotations * LHS pattern annotations can contain chunks

…om new) in a query (apache#5795)

* [incubator-kie-drools#5711] Broken OOPath expressions * accept mixing OOPath and standard constraint

) * [incubator-kie-drools#5742] [new-parser] Broken inline cast * fixed duplicate test

…pache#5811)

…pache#5812) * Improve no viable alternative example * Complete support for built-in operators * Enable soundslike test * Remove obsolete comment Co-authored-by: Toshiya Kobayashi <[email protected]> --------- Co-authored-by: Toshiya Kobayashi <[email protected]>

* Allow semicolon after type declaration end * Allow DRL keywords to be used as field names in type declarations

…che#5827) * [incubator-kie-drools-5798] [new-parser] Ensure Descr properties * [incubator-kie-issues#5798] Proposal * minor fix --------- Co-authored-by: Gabriele-Cardosi <[email protected]>

apache#5831) * [incubator-kie-drools-5716] [new-parser] mismatched input 'if'/'do' (support named consequences) * Update drools-drl/drools-drl-parser/src/main/antlr4/org/drools/drl/parser/antlr4/DRLLexer.g4 Co-authored-by: Jiří Locker <[email protected]> * Update drools-drl/drools-drl-parser/src/main/java/org/drools/drl/parser/antlr4/DRLVisitorImpl.java Co-authored-by: Jiří Locker <[email protected]> * resolve duplicate difinition --------- Co-authored-by: Jiří Locker <[email protected]>

) * Support isA operator and pluggable evaluators in general * Support class literals * Clean up drlPrimary rule

@members

…RL6Expressions.g4 (apache#5845) * WIP: import DRL6Expressions.g4 into DRLParser.g4 - Removed conflicting rules to make the antlr4 goal successful. - Java compilation fails because DRL6Expressions's @members section injects a DRL6Expression constructor and method overrides into DRLParser.java. * [incubator-kie-drools-5808] [new-parser] Combining DRLParser.g4 and DRL6Expressions.g4 - Modified DRL6Expressions.g4 @members to work with DRLParser - Now DRLParser holds ParserHelper - Fixed BigDecimal/BigInteger literal issues * - Reverted some parser rules which are no longer required after DRL6Expressions.g4 import --------- Co-authored-by: Jiří Locker <[email protected]>

…sts (apache#5855) * [incubator-kie-drools-5854] [new-parser] improve drools-drl-parser-testsa to test with old and new parsers - Old and new parser coverage using 2 surefire test executions - Fixed Descr common property issues to keep backward compatibility - A few test cases remaining without backward compatibility ("Backward Compatibility Notes" left) because the old parser seems to be wrong. - A few expr test cases remaining without backward compatibility ("Backward Compatibility Notes" left). Error code/message don't seem to be important. Also the new parser ones are better. * Update drools-drl/drools-drl-parser/src/main/java/org/drools/drl/parser/antlr4/LexerHelper.java Co-authored-by: Jiří Locker <[email protected]> * - removed unused import --------- Co-authored-by: Jiří Locker <[email protected]>

apache#5866) * [incubator-kie-drools-5714] Broken QueryTest#testRecursiveQueryWithBatchCommand * removed redandunt slimdown and toString

…che#5870)

* Fix AccumulateTest * Add GroupBy support

apache#5871) * [incubator-kie-drools-5724] [new-parser] Broken ExisistentialTest#test2NotsWithAnd * - Addtional test for LPAREN lhsExpression RPAREN namedConsequenceInvocation?

apache#5875) * [incubator-kie-drools-5784] Review DRLParser.g4 and DRL6Expressions.g4 to replace IDENTIFIER with drlIdentifier * - Removed unused methods

* Add OOPath support to lhsPattern * Set namespace and unit properties to PackageDescr children

…apache#5898)

apache#5899) * [incubator-kie-drools-5879] [new-parser] build failure on kie-dmn-validation - WIP - test case only * - nongreedy subrule * - Add tests - also fix andRestriction

…pache#5907)

…not, or, and exists (apache#5914)

apache#5921) * [incubator-kie-drools-5918] [new-parser] Annotations can appear in lhsOr and lhsAnd * - infix or, and

…apache#5922) - Avoid unnecessary IllegalStateException - Avoid empty error message

…ache#5913) * [incubator-kie-drools-5908] ReteOOWaltzTest 'end' detection issue * Update drools-drl/drools-drl-parser-tests/src/test/java/org/drools/drl/parser/antlr4/MiscDRLParserTest.java Co-authored-by: Jiří Locker <[email protected]> * Update drools-drl/drools-drl-parser-tests/src/test/java/org/drools/drl/parser/antlr4/MiscDRLParserTest.java Co-authored-by: Jiří Locker <[email protected]> * Update drools-drl/drools-drl-parser-tests/src/test/java/org/drools/drl/parser/antlr4/MiscDRLParserTest.java Co-authored-by: Jiří Locker <[email protected]> * Update drools-drl/drools-drl-parser-tests/src/test/java/org/drools/drl/parser/antlr4/MiscDRLParserTest.java Co-authored-by: Jiří Locker <[email protected]> * Update drools-drl/drools-drl-parser-tests/src/test/java/org/drools/drl/parser/antlr4/MiscDRLParserTest.java Co-authored-by: Jiří Locker <[email protected]> --------- Co-authored-by: Jiří Locker <[email protected]>

…apache#5941) * [incubator-kie-drools-5924] [new-parser] Disable DRLIncompleteCodeTest * Remove editor mode tests

…side OR (apache#5950) * Tests for incubator-kie-drools-5945 * [incubator-kie-drools-5945] [new-parser] Broken named consequences inside OR --------- Co-authored-by: Jiří Locker <[email protected]>

apache#5958) * [incubator-kie-drools-5818] [new-parser] Parsing fails if a Java keyword appears in a qualified name * - Exclude 'new' from 'drlIdentifier' because of 'primary' ambiguity - Add tests

apache#5965) * [incubator-kie-drools-5909] [new-parser] Accumulate parsed incorrectly if init and action statements are empty * Update drools-drl/drools-drl-parser-tests/src/test/java/org/drools/drl/parser/antlr4/MiscDRLParserTest.java Co-authored-by: Jiří Locker <[email protected]> --------- Co-authored-by: Jiří Locker <[email protected]>

…as alternatives to infix or and and (apache#5966)

apache#5969) * [incubator-kie-drools-5938] [new-parser] Tests using wrong duration attribute format * - Use explicit test value

…nAccumulateFunction (apache#5975)

…ted (apache#5979)

…pache#5976) - Skip the test for new parser

…d for backward compatibility (apache#5977)

…#5981)

…s test (apache#5983)

apache#5984)

* [incubator-kie-drools-5792] cleanup drools-drl-parser-tests - Apply open-rewrite JUnit5BestPractices * - Apply open-rewrite SimplifyChainedAssertJAssertions * - remove 'parse_' prefix - remove unused 'throw Exception' * - code format

- new parser is disabled by default

…ubator-kie-drools/pull/5989

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DO-NOT-MERGE] Enable new parser test for CI check in relation to incubator-kie-drools/pull/5989 #5990

[DO-NOT-MERGE] Enable new parser test for CI check in relation to incubator-kie-drools/pull/5989 #5990

Commits on Jun 11, 2024

[DO-NOT-MERGE] Enable new parser test for CI check in relation to incubator-kie-drools/pull/5989 #5990

Are you sure you want to change the base?

[DO-NOT-MERGE] Enable new parser test for CI check in relation to incubator-kie-drools/pull/5989 #5990

Commits on Jun 11, 2024