Added Issues Closed / Opened ratio in Issue trends #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the issues opened / issues closed ratio.
removed fractions import
|
Hi Adam, this looks great. Can you snake-case it please? |
| @@ -324,7 +325,8 @@ def run(API, environ, indata, session): | |||
| body = query | |||
| ) | |||
| no_closers_before = res['aggregations']['closer']['value'] | |||
|
|
|||
| issuesRatioBefore = round(float(no_issues_closed_before) / no_issues_created_before, 2) | |||
There was a problem hiding this comment.
Hey @amunz
Suggested change
| issuesRatioBefore = round(float(no_issues_closed_before) / no_issues_created_before, 2) | |
| issues_ratio_before = round(float(no_issues_closed_before) / no_issues_created_before, 2)§ |
Let's make it python style. ;)
| @@ -324,7 +325,8 @@ def run(API, environ, indata, session): | |||
| body = query | |||
| ) | |||
| no_closers_before = res['aggregations']['closer']['value'] | |||
|
|
|||
| issuesRatioBefore = round(float(no_issues_closed_before) / no_issues_created_before, 2) | |||
| issuesRatioAfter = str(round(float(no_issues_closed) / no_issues_created, 2)) | |||
There was a problem hiding this comment.
Suggested change
| issuesRatioAfter = str(round(float(no_issues_closed) / no_issues_created, 2)) | |
| issues_ratio_after = str(round(float(no_issues_closed) / no_issues_created, 2)) |
|
Hi folks. Please take a look #45. We are going to change the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please consider my contribution to add the metric issues closed / issues opened ratio. The metric is defined by the Chaoss project as an important metric for determining growth maturity and decline. More information on the metric can be found here.
Thank you for considering,
Adam