Optimize the download code for shared user readable

apache · May 28, 2021 · 51ca755 · 51ca755
1 parent c00f5f6
commit 51ca755
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/Entitlement.scala b/core/controller/src/main/scala/org/apache/openwhisk/core/entitlement/Entitlement.scala
@@ -376,10 +376,10 @@ protected[core] abstract class EntitlementProvider(
             .map(value => value.convertTo[String])
             .getOrElse(WhiskAction.defaultPermissions)
 
-          val errorInfo = s"have no permission to download this shared action"
-          val currentDownloadPermission = currentPermissions.charAt(3)
           if (user.namespace.name.asString != entityName.path.root.asString) { // the shared user who download the action
-            if (currentDownloadPermission == '-') {
+            val errorInfo = s"have no permission to download this shared action"
+            val downloadPermissionOfSharedUser = currentPermissions.charAt(3)
+            if (downloadPermissionOfSharedUser == '-') {
               Future.failed(RejectRequest(Forbidden, Some(ErrorResponse(errorInfo, transid))))
             } else {
               Future.successful(())