Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[fix] [broker] [branch-2.10] Upgrade rocksDB version to 6.29.4.1 to keep in sync with BookKeeper's RocksDB version #20287

Merged

Conversation

hangc0276
Copy link
Contributor

This reverts commit f88a49e.

Fixes #xyz

Master Issue: #xyz

PIP: #xyz

Motivation

Modifications

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

… sync with BookKeeper's RocksDB version (apache#20243)"

This reverts commit f88a49e.
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label May 10, 2023
@hangc0276 hangc0276 self-assigned this May 10, 2023
@hangc0276 hangc0276 changed the title Revert "[fix] [broker] Upgrade rocksDB version to 6.29.4.1 to keep in sync with BookKeeper's RocksDB version Revert "[fix] [broker] [branch-2.10] Upgrade rocksDB version to 6.29.4.1 to keep in sync with BookKeeper's RocksDB version May 10, 2023
@Technoboy-
Copy link
Contributor

/pulsarbot run-failure-checks

Copy link
Member

@dave2wave dave2wave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the reversion of the same upgrade in branch-2.9 was successful.

@dave2wave dave2wave merged commit 88038e3 into apache:branch-2.10 May 10, 2023
26 of 30 checks passed
liangyepianzhou added a commit to streamnative/pulsar-archived that referenced this pull request May 12, 2023
…to 6.29.4.1 to keep in sync with BookKeeper's RocksDB version (apache#20287)"

This reverts commit 88038e3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants