Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #8248]fix: getTotalBatchMaxBytes return holdSize #8249

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

humkum
Copy link
Contributor

@humkum humkum commented Jun 3, 2024

Fixes #8248

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 42.88%. Comparing base (949991e) to head (c3ee1c1).

Files Patch % Lines
...e/rocketmq/client/producer/ProduceAccumulator.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #8249      +/-   ##
=============================================
- Coverage      42.91%   42.88%   -0.04%     
+ Complexity     10380    10368      -12     
=============================================
  Files           1271     1271              
  Lines          88783    88783              
  Branches       11408    11408              
=============================================
- Hits           38102    38071      -31     
- Misses         45982    46005      +23     
- Partials        4699     4707       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@humkum
Copy link
Contributor Author

humkum commented Jun 5, 2024

@guyinyou @RongtongJin Please help to review this pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] fix auto batch getTotalBatchMaxBytes return holdSize
3 participants