Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): update tab drag and drop reordering with positional placement and indicators for UI**DO NOT MERGE** #29395

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rtexelm
Copy link
Contributor

@rtexelm rtexelm commented Jun 28, 2024

SUMMARY

Change reordering and UI specifically for Tab components within Tabs parent components across the codebase.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@rtexelm
Copy link
Contributor Author

rtexelm commented Jun 28, 2024

Still need to add/edit the tests and refine some things but this is the general idea.

@rtexelm rtexelm changed the title refactor(dashboard): update tab drag and drop reordering with positional placement and indicators for UI**DO NOT MERGE** feat(dashboard): update tab drag and drop reordering with positional placement and indicators for UI**DO NOT MERGE** Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant