Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add post re MyUW uPortal fork #41

Closed
wants to merge 5 commits into from

Conversation

apetro
Copy link
Contributor

@apetro apetro commented Dec 6, 2017

Add post describing MyUW's uPortal fork.

enhancements directly in upstream often felt like duplicated effort, since to
realize the improvement locally one also had to make it locally.

A more modern adoption model would obsessively make these improvements in
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"obsessively" sounds like a negatively loaded term, is that intended?


# Other fixes

+ Fix deleting permission grants via permissions management Portlet
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe rephrase? This could be ambiguous for folks that don't have in depth knowledge of portals permission system.


## Hacked rendering pipeline

MyUW configures the uPortal rendering pipeline to direct to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


MyUW has modified JSON APIs to expose data `uPortal-home` needs.

+ Expose more data about portlet publications, to power widgets. e.g. `renderOnWeb`,`mdIcon`, `widgetURL`, `widgetType`, `widgetConfig`, `widgetTemplate`, `widgetExternalMessageUrl`, `widgetExternalMesageTextObjectLocation`, `widgetExternalMessageLearnMoreUrlLocation`, in `LayoutPortlet`. See also idea to use portlet publishing parameters for this instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also idea to use portlet publishing parameters for this instead.

🔗 uPortal-Attic/uportal-home#753

+ Add `firstName`, `lastName` in the `SessionRESTController` response. Also, `originalUsername` when swapped.
+ Add some error handling in `LayoutPortlet` to catch when `widgetConfig` is not valid JSON.
+ Increase time-to-live of `marketplacePortletDefinitionCache`
+ Filter marketplace entries to only those in `PUBLISHED` publication lifecycle state. (Arguably this should be more nuanced, reflecting the viewing user's permissions -- maybe you've got permission to see entries that are in states other than `PUBLISHED`).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


MyUW has modified DLM to simplify the user experience of adding content to one's homepage.

+ Default adding a new item to the first rather than last position in a container.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was an effort to upstream this in uPortal-Project/uPortal#885 the PR stalled before it could be merged. 😞

@@ -0,0 +1,168 @@
---
layout: post
title: MyUW uPortal fork: the good parts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm cautious about phrasing here.
The article is about features and optimization made by MyUW's portal, changes which I hope to see upstreamed or reconciled with Apereo uPortal.
This title could be misconstrued as advocating for forking Apereo uPortal, which I don't think is the article's goal.


MyUW uses a customized "Bucky" theme forked from Respondr. The purpose of this customized theme and associated skins is to make rendering a portlet maximized via uPortal look like rendering uPortal-home, so that users switch reasonably seamlessly between the two approaches depending on content.

+ Fewer regions. Simpler. Remove features MyUW isn't using.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uPortal 5 has changed a number of regions to portlets that can easily be removed. E.G. uPortal-Project/uPortal#1081

+ Rest Proxy
+ Key-value store
+ LTI Redirector
+ Personalized Redirector
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these services rely on a forked version of the portal?

@stale
Copy link

stale bot commented May 1, 2018

This patch has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Pending label May 1, 2018
@apetro
Copy link
Contributor Author

apetro commented May 1, 2018

Still intend to circle back on this.

@stale stale bot removed the Pending label May 1, 2018
@stale
Copy link

stale bot commented May 8, 2018

This issue/patch has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Pending label May 8, 2018
@stale
Copy link

stale bot commented May 15, 2018

This patch/patch has been automatically closed because it has not had recent activity. If you wish to resume work, please re-open the pull request and continue as usual. Thank you for your contributions.

@stale stale bot closed this May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants