bugfix: trace main thread only #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When some new features, e.g. grpc-client-nginx-module, lua-resty-ffi are used, the nginx worker process has multiple threads. CPU flamegraph is only meaningful for the main thread, which runs nginx event loop and lua code, so we should ignore other threads. `tid()` gets the thread id, and in Linux, the process id is just equal to its main thread id, so we should use `tid()` to match `target()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When some new features are used, e.g. grpc-client-nginx-module, lua-resty-ffi, the nginx worker process has multiple threads.
CPU flamegraph is only meaningful for the main thread, which runs nginx event loop and lua code, so we should ignore other threads.
tid()gets the thread id, and in Linux, the process id is just equal to its main thread id, so we should usetid()to matchtarget().