Acceptance link issue when the same mail address due to a case-sensitive error. #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.x #1031 +/- ##
=========================================
Coverage 44.37% 44.37%
Complexity 3041 3041
=========================================
Files 342 342
Lines 11111 11111
=========================================
Hits 4931 4931
Misses 6180 6180 |
mxr576
reviewed
Jan 26, 2024
| @@ -190,7 +190,9 @@ public function setStatus(int $status): TeamInvitationInterface { | |||
| * {@inheritdoc} | |||
| */ | |||
| public function getRecipient(): ?string { | |||
| return $this->get('recipient')->value; | |||
| $recipientEmail = $this->get('recipient')->value;; | |||
There was a problem hiding this comment.
There is an extra ; at the end of the line.
mxr576
reviewed
Jan 26, 2024
| @@ -190,7 +190,9 @@ public function setStatus(int $status): TeamInvitationInterface { | |||
| * {@inheritdoc} | |||
| */ | |||
| public function getRecipient(): ?string { | |||
| return $this->get('recipient')->value; | |||
| $recipientEmail = $this->get('recipient')->value;; | |||
| $user = user_load_by_mail($recipientEmail); | |||
There was a problem hiding this comment.
Loading user approach looks quite expensive and if the email server case sensitive then it could also lead to problems.
Case sensitivity is a delicate topic anyway...
kedarkhaire
force-pushed
the
vpa24-acceptance-link-problem-with-mixed-case-email-addresss
branch
from
5eb0f8c
to
701ba31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When inviting a new member to my team, consider the following example: the user's email is [email protected], but I entered [email protected]. When they click on the acceptance link, they can't join the team due to a case-sensitive error.
In my code, it first retrieves the user object using the
user_load_by_mailfunction with the recipient's email. If the user object is found, it retrieves the original user's email; otherwise, it obtains the recipient's email.