Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurability of log attributes #5540

Open
BrynCooke opened this issue Jun 26, 2024 · 2 comments
Open

Configurability of log attributes #5540

BrynCooke opened this issue Jun 26, 2024 · 2 comments

Comments

@BrynCooke
Copy link
Contributor

BrynCooke commented Jun 26, 2024

Currently when configuring the attributes that are output onto log events we have the following:

telemetry:
  exporters:
    logging: 
      stdout:
        format: 
          json:
            display_span_list: true # Output all attributes from all spans to the root
            display_current_span: true # Output attributes from the current span

When following the otel conventions there can be a large number of span attributes, and users need the ability to specify which attributes should be output rather than the all or nothing settings we have already.

Users needs to be able to opt in to attributes so that they can be sure that only the attributes they want are output.

@Samjin
Copy link

Samjin commented Jun 27, 2024

The PRs that closed items 3 and 4 are linked in the description, but is also here: #5447

So to confirm, this ticket can sample a custom trace id. 3 & 4 from last ticket would help to append to custom request logs. Does 3/4 allow custom trace id format like UUID? Based on the router schema definition 3 and 4 requires hexadecimal/ decimal, open_telemetry/datadog format, or are these format specific for experimental_response_trace_id feature only?

@Samjin
Copy link

Samjin commented Jul 2, 2024

a1e81c42-5558-4b62-a363-a6dbcc1014dc as example trace id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants