chore: bump minimum versions to fix e2e using bazel-lib 2.x

archen · Feb 29, 2024 · c45c2d6 · c45c2d6
1 parent 8a93981
commit c45c2d6
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 10 deletions.
diff --git a/MODULE.bazel b/MODULE.bazel
@@ -9,12 +9,13 @@ module(
 # Lower-bound (minimum) versions of direct dependencies
 bazel_dep(name = "bazel_skylib", version = "1.3.0")
 
-# Need #397 to skip stardoc targets
-bazel_dep(name = "aspect_bazel_lib", version = "1.30.2")
+# Need feat: backport 2.x features for interoperability by @kormide in #657
+bazel_dep(name = "aspect_bazel_lib", version = "1.38.0")
 
 # 1.19.0: Need attribute 'dev' in 'npm_package_store_internal' rule
 # 1.29.2: Need Windows fix to disable fs patches
-bazel_dep(name = "aspect_rules_js", version = "1.29.2")
+# 1.31.1: fix: allow for Bazel 7 flag rename (#1178)
+bazel_dep(name = "aspect_rules_js", version = "1.31.0")
 bazel_dep(name = "rules_nodejs", version = "5.5.3")
 bazel_dep(name = "platforms", version = "0.0.5")
 

diff --git a/WORKSPACE b/WORKSPACE
@@ -11,6 +11,10 @@ load("//rollup:dependencies.bzl", "rules_rollup_dependencies")
 # Fetch dependencies which users need as well
 rules_rollup_dependencies()
 
+load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")
+
+rules_js_dependencies()
+
 load("@rules_nodejs//nodejs:repositories.bzl", "nodejs_register_toolchains")
 
 nodejs_register_toolchains(

diff --git a/e2e/smoke/MODULE.bazel b/e2e/smoke/MODULE.bazel
@@ -1,8 +1,9 @@
 "Bazel dependencies"
 
 bazel_dep(name = "aspect_rules_rollup", version = "0.0.0", dev_dependency = True)
+bazel_dep(name = "aspect_bazel_lib", version = "2.2.0", dev_dependency = True)
 bazel_dep(name = "bazel_skylib", version = "1.3.0", dev_dependency = True)
-bazel_dep(name = "aspect_rules_js", version = "1.29.2", dev_dependency = True)
+bazel_dep(name = "aspect_rules_js", version = "1.35.0", dev_dependency = True)
 
 local_path_override(
     module_name = "aspect_rules_rollup",

diff --git a/e2e/smoke/WORKSPACE.bazel b/e2e/smoke/WORKSPACE.bazel
@@ -18,6 +18,10 @@ load("@aspect_rules_rollup//rollup:dependencies.bzl", "rules_rollup_dependencies
 # already fetched all the dependencies.
 rules_rollup_dependencies()
 
+load("@aspect_rules_js//js:repositories.bzl", "rules_js_dependencies")
+
+rules_js_dependencies()
+
 # Fetch and register a node toolchain, if you haven't already
 load("@rules_nodejs//nodejs:repositories.bzl", "DEFAULT_NODE_VERSION", "nodejs_register_toolchains")
 

diff --git a/rollup/dependencies.bzl b/rollup/dependencies.bzl
@@ -11,16 +11,16 @@ def rules_rollup_dependencies():
 
     http_archive(
         name = "aspect_bazel_lib",
-        sha256 = "97fa63d95cc9af006c4c7b2123ddd2a91fb8d273012f17648e6423bae2c69470",
-        strip_prefix = "bazel-lib-1.30.2",
-        url = "https://github.com/aspect-build/bazel-lib/releases/download/v1.30.2/bazel-lib-v1.30.2.tar.gz",
+        sha256 = "b848cd8e93be7f18c3deda6d2f3ade92a657d3585e119953bc50dc75fef535c2",
+        strip_prefix = "bazel-lib-1.38.0",
+        url = "https://github.com/aspect-build/bazel-lib/releases/download/v1.38.0/bazel-lib-v1.38.0.tar.gz",
     )
 
     http_archive(
         name = "aspect_rules_js",
-        sha256 = "7cb2d84b7d5220194627c9a0267ae599e357350e75ea4f28f337a25ca6219b83",
-        strip_prefix = "rules_js-1.29.2",
-        url = "https://github.com/aspect-build/rules_js/releases/download/v1.29.2/rules_js-v1.29.2.tar.gz",
+        sha256 = "7b2a4d1d264e105eae49a27e2e78065b23e2e45724df2251eacdd317e95bfdfd",
+        strip_prefix = "rules_js-1.31.0",
+        url = "https://github.com/aspect-build/rules_js/releases/download/v1.31.0/rules_js-v1.31.0.tar.gz",
     )
 
     http_archive(