Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New disk management program #1053

Open
wants to merge 116 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 44 commits
Commits
Show all changes
116 commits
Select commit Hold shift + click to select a range
9d0ca46
Initial load of diskmanager
wllacer Mar 30, 2022
990d6bb
no PR without flake8 complains
wllacer Mar 30, 2022
8389912
allow percentages in input json file
wllacer Mar 30, 2022
2a4fd19
solve some errors at generated json
wllacer Mar 30, 2022
b625255
Updates to json generator
wllacer Mar 30, 2022
b6e6ddf
Get real sector size.
wllacer Mar 31, 2022
440bf7f
sizeG shown at PartitionMenu if available
wllacer Mar 31, 2022
d1e0f72
At new partitions its space is presented as part of a free space slot.
wllacer Mar 31, 2022
b5d3bcd
Correct exit procedure when quitting trying to allocate space
wllacer Mar 31, 2022
12f2e36
convert_units now defaults to sectors as unnamed input.
wllacer Apr 1, 2022
12cb1d3
Correct management of % sizes.
wllacer Apr 1, 2022
d0c0163
More flexible location management for add partition
wllacer Apr 1, 2022
9f269c7
generation of sizeG argument
wllacer Apr 1, 2022
1d053ee
reserved 34 sectors at the end of disk (GPT need)
wllacer Apr 1, 2022
3490063
small bugs squashing. Most notably, the new way to check if a partiti…
wllacer Apr 3, 2022
8b1b15f
Action exclude partition from installation set deactivated.
wllacer Apr 3, 2022
0fd0981
Merge branch 'master' into diskmanager
wllacer Apr 4, 2022
8f14592
Add readonly information (uuid,actual_mountpoint,actual_subvolumes) t…
wllacer Apr 4, 2022
f5c6d98
On exit via cancel at DevList, partitions to delete is cleared
wllacer Apr 5, 2022
0857ef2
We make the last action available beyond the run loop, so we can chec…
wllacer Apr 5, 2022
d2976a9
Merge branch 'dmsupport' into diskmanager
wllacer Apr 5, 2022
660c294
On exit via cancel at DevList, partitions to delete is cleared (corre…
wllacer Apr 5, 2022
6dd5c5c
cleanup debug info
wllacer Apr 5, 2022
520aaf1
When using disk_layout files but not config file, we autofill the har…
wllacer Apr 5, 2022
b50dfa0
Merge branch 'dmsupport2' into diskmanager
wllacer Apr 5, 2022
4291fb1
Integrate only_hd into diskmanager.
wllacer Apr 5, 2022
d846acf
for once flake8 was useful
wllacer Apr 5, 2022
167167a
Created a routine to check if a partition includes a certain mountpoint
wllacer Apr 6, 2022
e2516d4
delete partition is now operative
wllacer Apr 8, 2022
f2efea5
Merge branch 'dmsupport3' into diskmanager
wllacer Apr 8, 2022
d1016be
No more gaps are presented in [structure]. It seems they're not neede…
wllacer Apr 8, 2022
a8de206
Revert "No more gaps are presented in [structure]. It seems they're n…
wllacer Apr 8, 2022
e1d97e2
Don't create gaps for structure
wllacer Apr 8, 2022
1bf4f7a
password handling restored.
wllacer Apr 8, 2022
d689635
if disk exists and fs changed wipe=true
wllacer Apr 8, 2022
b2d54c1
basic alignment code in select_physical
wllacer Apr 12, 2022
f336140
Merge branch 'master' into diskmanager
wllacer Apr 17, 2022
c85bbbd
Does not gives error while reading MBR disks
wllacer Apr 18, 2022
ab76909
Merge branch 'master' into diskmanager
wllacer Jun 8, 2022
f549d76
band-aid
wllacer Jun 9, 2022
983bcae
Merge branch 'master' into diskmanager
wllacer Jun 16, 2022
73cea81
Adapted to new list_manager. Many things still don't work
wllacer Jun 17, 2022
49b27ac
band-aid (II) subvolume handling with dataclass. still has lot of old…
wllacer Jun 22, 2022
696b072
Flake8 complains
wllacer Jun 22, 2022
46f226e
Enhacements to list_manager:
wllacer Jun 22, 2022
f6a79df
Merge branch 'listmgr_enh' into diskmanager
wllacer Jun 22, 2022
2c314e1
integrated listmgr_enh new options
wllacer Jun 22, 2022
d1b5caa
last_choice is now a calculated attribute, therefore readonly
wllacer Jun 28, 2022
95e264a
A number of corrections at PartitionMenu
wllacer Jun 28, 2022
2a56020
Some more corrections for the subvolume handling
wllacer Jun 29, 2022
e75af61
Solves issue 1343. Could not locate partition after creation
wllacer Jun 30, 2022
74ce0c3
Merge branch 'issue1343' into diskmanager
wllacer Jul 1, 2022
4635773
Some more corrections for the subvolume handling. Hope this is it, mi…
wllacer Jul 1, 2022
cb51a3d
actual_subvolumes uses now Subvolume dataclass.
wllacer Jul 1, 2022
c17cb9d
actual_subvolumes uses now Subvolume dataclass.
wllacer Jul 1, 2022
9054767
Merge branch 'diskmanager' of https://github.com/wllacer/archinstall …
wllacer Jul 1, 2022
253caf8
actual_subvolumes uses now Subvolume dataclass.
wllacer Jul 1, 2022
8d6a34c
docstring at unit_best_fit
wllacer Jul 4, 2022
0bbb7a2
Creation of diskmanager directory
wllacer Jul 4, 2022
14b6e6d
Creation of a basic list user interface for the dataclasses
wllacer Jul 5, 2022
d7ab8a3
Formatting of output is now class dependant
wllacer Jul 5, 2022
ff8e941
Basic load from disk_layouts
wllacer Jul 5, 2022
789edfa
layout generator set in place
wllacer Jul 6, 2022
2fb3a97
first iteration of partition list
wllacer Jul 6, 2022
eb8aaa8
Partition list working ... except those that need PartitionMenu
wllacer Jul 6, 2022
07ca228
partition menu ready to test but _select_physical
wllacer Jul 7, 2022
efebda4
advances in select_physical
wllacer Jul 7, 2022
666363a
select_physical completed
wllacer Jul 9, 2022
eae0f10
bug hunting
wllacer Jul 9, 2022
de9c10c
Moved diskmanager directory to lib/user_interaction
wllacer Jul 9, 2022
2120cba
creating glue elements
wllacer Jul 11, 2022
8f68fe6
bug hunting.
wllacer Jul 11, 2022
ba7eabf
Merge branch 'diskmanager2' into diskmanager
wllacer Jul 11, 2022
9ec0cf3
minimal reformat
wllacer Jul 11, 2022
3bfbb11
flake8 complains
wllacer Jul 11, 2022
8116fe5
restoring ability to use a predefined installation directory
wllacer Jul 11, 2022
409dfec
Merge branch 'mntarch' into diskmanager
wllacer Jul 11, 2022
5696770
simplified diskmanager.py
wllacer Jul 11, 2022
07d2874
glue.py formatted
wllacer Jul 11, 2022
fba796e
dataclasses.py formatted
wllacer Jul 12, 2022
4257388
discovery.py formatted
wllacer Jul 12, 2022
7637474
generator.py and helper.py formatted
wllacer Jul 12, 2022
5204ef0
flake8 complains.
wllacer Jul 12, 2022
4521deb
partition_list.py formatted
wllacer Jul 12, 2022
bfea718
partition_menu.py formatted
wllacer Jul 12, 2022
0ca6773
cleanup at guided.py
wllacer Jul 12, 2022
17590f1
user error handler at partition_menu
wllacer Jul 13, 2022
ed73a6b
round up of bugs and missing features at PartitionMenu
wllacer Jul 13, 2022
e54cbe7
enhacements to FormattedOutput
wllacer Jul 14, 2022
14e8822
flake8 complain
wllacer Jul 15, 2022
b1d4dd0
flexible calling mechanism for guided.py
wllacer Jul 15, 2022
cf5fa8c
updated also at only_hd and swiss
wllacer Jul 15, 2022
d90a6f8
Merge branch 'issue1343' into new-guided
wllacer Jul 15, 2022
12ea1b5
Merge branch 'new-guided' into diskmanager
wllacer Jul 19, 2022
b1ff394
Merge branch 'listmgr_enh' into diskmanager
wllacer Jul 19, 2022
78a9eeb
bug hunting. Added last_choice to selection_menu
wllacer Jul 19, 2022
e352ed4
Added last_choice to selection_menu
wllacer Jul 19, 2022
e50b30d
Merge branch 'listmgr_enh' into diskmanager
wllacer Jul 19, 2022
f813312
solving todo entries at partition_list
wllacer Jul 19, 2022
35ed666
Merge branch 'formatted_output' into diskmanager
wllacer Jul 19, 2022
e5bc863
Adapted diskmanager to PR 1376 (new FormattedOutput)
wllacer Jul 19, 2022
e1bac0c
flake8 complains
wllacer Jul 19, 2022
a8e9b47
restore short & longform
wllacer Jul 20, 2022
1a23d49
round up formatting DevList
wllacer Jul 20, 2022
7e0546c
bug hunting
wllacer Jul 20, 2022
96403e5
bug at selection_menu handling. Translations can be a problem
wllacer Jul 20, 2022
4415900
Merge branch 'listmgr_enh' into diskmanager
wllacer Jul 20, 2022
b8e868e
check_coherence at partition_list.py
wllacer Jul 21, 2022
3ea96e1
correct a number of wrong uses of _()
wllacer Jul 21, 2022
2e0c12f
flake8 complain
wllacer Jul 21, 2022
dcc969b
solving bug to make parted work flawlessly (using mib as unit for sta…
wllacer Jul 21, 2022
628447c
ADD MENU presentation can be switched via argument dm_add_menu.
wllacer Jul 22, 2022
6e5fc8c
partitionMenu mountpoint doesn't depend of filesystem (should but it …
wllacer Jul 22, 2022
5a8a037
enhacements in the add partition workflow.
wllacer Jul 23, 2022
eebbe22
I decided to exit the location entry at PartitionMenu with an user ex…
wllacer Jul 27, 2022
7a76571
Merge branch 'master' into diskmanager
wllacer Jul 27, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions archinstall/lib/disk/helpers.py
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,6 @@ def has_mountpoint(partition: Union[dict,Partition,MapperDev], target: str, stri
Input parms:
:parm partition the partition we check
:type Either a Partition object or a dict with the contents of a partition definition in the disk_layouts schema

:parm target (a string representing a mount path we want to check for.
:type str

Expand All @@ -493,7 +492,6 @@ def has_mountpoint(partition: Union[dict,Partition,MapperDev], target: str, stri
mountpoints += [volume.mountpoint for volume in subvolumes]
else:
mountpoints = [partition.mountpoint,] + [subvol.target for subvol in partition.subvolumes]

# we check
if strict or target == '/':
if target in mountpoints:
Expand Down
2 changes: 1 addition & 1 deletion archinstall/lib/menu/list_manager.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ def run(self):
# this will return a dictionary with the key as the menu entry to be displayed
# and the value is the original value from the self._data container
data_formatted = self.reformat(self._data)

options, header = self._prepare_selection(data_formatted)

system('clear')
Expand Down Expand Up @@ -83,7 +84,6 @@ def _prepare_selection(self, data_formatted: Dict[str, Any]) -> Tuple[List[str],
# to exclude those from the selectable data
options: List[str] = [key for key, val in data_formatted.items() if val is not None]
header = ''

if len(options) > 0:
table_header = [key for key, val in data_formatted.items() if val is None]
header = '\n'.join(table_header)
Expand Down
1 change: 1 addition & 0 deletions archinstall/lib/user_interaction/partitioning_conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from ..output import log, FormattedOutput

from ..disk.validators import fs_types
from ..disk.helpers import has_mountpoint

if TYPE_CHECKING:
from ..disk import BlockDevice
Expand Down
2 changes: 1 addition & 1 deletion examples/disk_layouts-sample.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"@pkgs": "/var/cache/pacman/pkg"
}
},
"encrypted": true,
"encrypted": false,
"filesystem": {
"format": "btrfs"
},
Expand Down
Loading