chore: remove event grid from testing & upgrade az func definitions #893
Conversation
✅ Deploy Preview for arcus-templates canceled.
|
stijnmoreels
changed the title
| - group: 'Arcus Web Api - Integration Testing' | ||
| # We are re-using the Event Grid integration infrastructure | ||
| - group: 'Arcus Messaging - Integration Testing' | ||
| - group: 'Arcus Background Jobs - Integration Testing' |
There was a problem hiding this comment.
I don't understand why we're not running these tests anymore ?
The PR title just speaks about removing event-grid from testing ?
There was a problem hiding this comment.
We're still running the tests, we're just not using EventGrid anymore to run them. Now we use the file system as the event source instead.
| /// <summary> | ||
| /// Processes Azure EventHubs <paramref name="events"/>. | ||
| /// Processes Azure EventHubs <paramref name="datas"/>. |
There was a problem hiding this comment.
Isn't data already plural ?
events was -imho- correct.
| for (var index = 0; index < events.Length; index++) | ||
| logger.LogInformation("Azure EventHubs function triggered with {Length} events", datas.Length); | ||
|
|
||
| foreach (EventData data in datas) |
There was a problem hiding this comment.
I think I know why you renamed events to datas.
Is it because event is a keyword in C#, and you cannot write foreach( var event in events)?
You can work around that by 'escaping' the keyword, like this foreach( var @event in events)
There was a problem hiding this comment.
Might me me that I automatically used the last name of the type as variable name 😅
Remove the unnecessary EventGrid testing from the project template testing and use the file system as target source to send messages from worker templates to.