Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in find and filter with an empty store #6265

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

snstanton
Copy link

@snstanton snstanton commented Jun 13, 2024

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of
the pull request.

Description

In MockStore, this change guards against an empty store in calls to filter/find to avoid calling Object.values() on undefined.

Related #6262

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take
action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can
reproduce. Please also list any relevant details for your test configuration

  • store.spec.ts:filter method
  • store.spec.ts:find method

Test Environment:

  • OS: macos
  • @graphql-tools/mock: 9.0.3
  • NodeJS: v22.2.0

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests and linter rules pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Further comments

None

Copy link

changeset-bot bot commented Jun 13, 2024

🦋 Changeset detected

Latest commit: 0b95888

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-tools/mock Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@snstanton snstanton changed the title Fix errors in find and filter with an empty store (#6262) Fix errors in find and filter with an empty store Jun 13, 2024
@ardatan
Copy link
Owner

ardatan commented Jun 22, 2024

Thanks for the PR!
Could you create a changeset using yarn changeset then we can merge and release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants