Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stitch): Do not apply isolation for Mutation root fields #6293

Merged
merged 3 commits into from
Jul 1, 2024

Conversation

ardatan
Copy link
Owner

@ardatan ardatan commented Jun 27, 2024

No description provided.

Copy link

changeset-bot bot commented Jun 27, 2024

🦋 Changeset detected

Latest commit: c4c87c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@graphql-tools/federation Patch
@graphql-tools/stitch Patch
federation-benchmark Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ardatan ardatan changed the title Fix isolation for mutation fix(stitch): Do not apply isolation for Mutation root fields Jun 27, 2024
Copy link
Contributor

github-actions bot commented Jun 27, 2024

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 326       ✗ 0  
     data_received..................: 38 MB   3.8 MB/s
     data_sent......................: 140 kB  14 kB/s
     http_req_blocked...............: avg=3.9µs    min=2µs      med=2.58µs   max=176.4µs  p(90)=3.88µs  p(95)=4.11µs  
     http_req_connecting............: avg=701ns    min=0s       med=0s       max=114.37µs p(90)=0s      p(95)=0s      
     http_req_duration..............: avg=57.25ms  min=49.32ms  med=53.81ms  max=152.82ms p(90)=64.54ms p(95)=87.89ms 
       { expected_response:true }...: avg=57.25ms  min=49.32ms  med=53.81ms  max=152.82ms p(90)=64.54ms p(95)=87.89ms 
     http_req_failed................: 0.00%   ✓ 0         ✗ 163
     http_req_receiving.............: avg=138.95µs min=105.58µs med=129.23µs max=528.51µs p(90)=150.5µs p(95)=161.29µs
     http_req_sending...............: avg=24.67µs  min=18.66µs  med=22.64µs  max=56.69µs  p(90)=30.53µs p(95)=36.14µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s      p(95)=0s      
     http_req_waiting...............: avg=57.09ms  min=49.04ms  med=53.62ms  max=152.46ms p(90)=64.37ms p(95)=87.74ms 
     http_reqs......................: 163     16.253613/s
     iteration_duration.............: avg=61.5ms   min=52.9ms   med=57.83ms  max=156.92ms p(90)=69.5ms  p(95)=91.88ms 
     iterations.....................: 163     16.253613/s
     vus............................: 1       min=1       max=1
     vus_max........................: 1       min=1       max=1

Copy link
Contributor

github-actions bot commented Jun 27, 2024

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-tools/federation 2.1.1-alpha-20240701111845-c4c87c32ed59922725fdb64813bd4f1cf733e59c npm ↗︎ unpkg ↗︎
@graphql-tools/stitch 9.2.10-alpha-20240701111845-c4c87c32ed59922725fdb64813bd4f1cf733e59c npm ↗︎ unpkg ↗︎

Copy link
Contributor

github-actions bot commented Jun 27, 2024

💻 Website Preview

The latest changes are available as preview in: https://4de0d583.graphql-tools.pages.dev

@ardatan ardatan marked this pull request as ready for review July 1, 2024 11:13
@ardatan ardatan merged commit 3f301dc into master Jul 1, 2024
22 of 27 checks passed
@ardatan ardatan deleted the fix-isolation-for-mutation branch July 1, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant