Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed integration test #2164

Merged
merged 1 commit into from
May 2, 2023
Merged

Fixed integration test #2164

merged 1 commit into from
May 2, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented May 2, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Fixed integration test by removing dependency on external core.

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

Other information

@cmaglie cmaglie self-assigned this May 2, 2023
@cmaglie cmaglie added topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement labels May 2, 2023
@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (ad9ddb8) 62.49% compared to head (e80cd1f) 62.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2164      +/-   ##
==========================================
+ Coverage   62.49%   62.51%   +0.02%     
==========================================
  Files         223      223              
  Lines       19472    19462      -10     
==========================================
- Hits        12169    12167       -2     
+ Misses       6205     6201       -4     
+ Partials     1098     1094       -4     
Flag Coverage Δ
unit 62.51% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cmaglie cmaglie merged commit ebdef4d into arduino:master May 2, 2023
@cmaglie cmaglie deleted the fix_test branch May 2, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants