-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(argo-rollouts): Add traefik.io api group #2703
Conversation
This requires argo rollouts 1.7.0 as well, which did not release yet |
charts/argo-rollouts/Chart.yaml
Outdated
- kind: added | ||
description: Added pod labels for the controller and the dashboard components |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the chart changelog with all the changes that come with this pull request according to changelog.
Please remove old one.
I have bumped the chart version according to versioning
Also please bump version.
Hi @Kaswob , thank you for the PR. |
32bd2c0
to
ec70d41
Compare
@yu-croco bumped version and removed old changelog entry. I've also updated AppVersion to 1.7.0 so it will be ready for upstream release. Thanks for the info @DrFaust92 |
@@ -248,6 +248,7 @@ rules: | |||
# Traefik access needed when using the Traefik provider | |||
- apiGroups: | |||
- traefik.containo.us | |||
- treafik.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, thanks for noticing ;) Fixed
Add traefik.io (which is the only supported apiGroup for traefik >3.0) to clusterrole and role of argo-rollouts chart Signed-off-by: Kamil Swoboda <[email protected]>
ec70d41
to
9c506b1
Compare
Kaswob any movement on this? if not ill try to fork of off you so your commits will get it. |
Signed-off-by: Kaswob <[email protected]>
@DrFaust92 @yu-croco bumped version, should be fine now. Sorry for the delay, I've been a bit busy recently and missed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, LGTM.
Add traefik.io (which is the only supported apiGroup for traefik >3.0) to clusterrole and role of argo-rollouts chart
Checklist: