fix(argo-events): Update Jetstream versions as following upstream #2790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yu-croco
force-pushed
the
update-jetstream-versions
branch
from
9500921
to
a57797c
Compare
Signed-off-by: yu-croco <[email protected]>
yu-croco
force-pushed
the
update-jetstream-versions
branch
from
a57797c
to
dd2db48
Compare
yu-croco
commented
Jun 22, 2024
| @@ -33,6 +33,51 @@ data: | |||
| replicas: {{ .Values.configs.jetstream.streamConfig.replicas }} | |||
| duplicates: {{ .Values.configs.jetstream.streamConfig.duplicates }} | |||
| versions: | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
Is it better to defined in values.yaml ...? 🤔
There was a problem hiding this comment.
Thank you for reviewing. I will update values.yaml instead of configmap. 🙋
There was a problem hiding this comment.
I handled in 761d5d8 📝
yu-croco
force-pushed
the
update-jetstream-versions
branch
3 times, most recently
from
2ea7439
to
fbdcc74
Compare
Signed-off-by: yu-croco <[email protected]>
yu-croco
force-pushed
the
update-jetstream-versions
branch
from
fbdcc74
to
a28d33a
Compare
Signed-off-by: yu-croco <[email protected]>
jmeridth
approved these changes
Jun 23, 2024
tico24
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2787
Checklist: