Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(argo-rollouts): Fix of global subscriptions for Argo Rollouts #2797

Merged
merged 7 commits into from
Jun 26, 2024
Merged

fix(argo-rollouts): Fix of global subscriptions for Argo Rollouts #2797

merged 7 commits into from
Jun 26, 2024
+10 −10

Conversation

ajax-bychenok-y
Copy link
Contributor

@ajax-bychenok-y ajax-bychenok-y commented Jun 25, 2024 •
edited
Loading

Fix to these changes #2793 which previously seems was not tested.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

yu-croco
yu-croco previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution.
I should've checked existing code in previous PR.🫠

LGTM.

@yu-croco yu-croco changed the title Fix of global subscriptions for Argo Rollouts fix(argo-rollouts): Fix of global subscriptions for Argo Rollouts Jun 25, 2024
yu-croco
yu-croco reviewed Jun 25, 2024
View reviewed changes
charts/argo-rollouts/Chart.yaml Outdated Show resolved Hide resolved
charts/argo-rollouts/values.yaml Outdated Show resolved Hide resolved
@ajax-bychenok-y
Copy link
Contributor Author

Updated doc with ./scripts/helm-docs.sh.

yu-croco
yu-croco approved these changes Jun 26, 2024
View reviewed changes
Copy link
Collaborator

@yu-croco yu-croco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. LGTM

@mbevc1 mbevc1 merged commit 425e98e into argoproj:main Jun 26, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbevc1 mbevc1 mbevc1 approved these changes

@yu-croco yu-croco yu-croco approved these changes

@jmeridth jmeridth Awaiting requested review from jmeridth jmeridth is a code owner

@mkilchhofer mkilchhofer Awaiting requested review from mkilchhofer

@pdrastil pdrastil Awaiting requested review from pdrastil

@tico24 tico24 Awaiting requested review from tico24

Assignees
No one assigned
Labels
argo-rollouts size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ajax-bychenok-y @mbevc1 @yu-croco