fix(argo-cd): Missing Redis sentinel variables in app controller deployment #2806
+17
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horjulf
requested review from
mbevc1,
mkilchhofer,
yu-croco,
jmeridth,
pdrastil and
tico24
as code owners
|
Should the env vars be moved to a helper function to avoid sync issues in the future ? |
yu-croco
changed the title
horjulf
force-pushed
the
redis-sentinel-app
branch
from
ec0109b
to
eeea4ad
Compare
|
Rebased |
horjulf
force-pushed
the
redis-sentinel-app
branch
4 times, most recently
from
6d35b29
to
f96da5b
Compare
…oyment Signed-off-by: Filipe Santos <[email protected]>
horjulf
force-pushed
the
redis-sentinel-app
branch
from
f96da5b
to
1fc9580
Compare
|
@yu-croco Thanks for updating the title, I've made another rebase and updated the commit to reflect the chart scope. |
mbevc1
approved these changes
Jul 17, 2024
yu-croco
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds missing Redis sentinel variables to Application Controller deployment. Was missed in #2492
Sync optional attribute to deployment following the STS fix in #2800
Checklist: