Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(argocd-image-updater): Update dependency argoproj-labs/argocd-image-updater to v0.14.0 #2809

Merged
merged 7 commits into from
Jul 9, 2024

Conversation

argoproj-renovate[bot]
Copy link
Contributor

This PR contains the following updates:

Package Update Change
argoproj-labs/argocd-image-updater minor v0.13.1 -> v0.14.0

Release Notes

argoproj-labs/argocd-image-updater (argoproj-labs/argocd-image-updater)

v0.14.0

Compare Source

What's Changed

New Contributors

Full Changelog: argoproj-labs/argocd-image-updater@v0.13.0...v0.14.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@yu-croco
Copy link
Collaborator

yu-croco commented Jul 8, 2024

There were some manifests updates in upstream, so I added commit. 🙋 FYI

@github-actions github-actions bot added size/M and removed size/XS labels Jul 8, 2024
@argoproj-renovate
Copy link
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@Fluder-Paradyne
Copy link

Hi @yu-croco,

I hope you're doing well. I'm really looking forward to the new release!

I noticed that I couldn't find git.commit-signing-key and git.commit-signing-method in the following file:
https://github.com/argoproj/argo-helm/blob/main/charts/argocd-image-updater/templates/configmap.yaml#L24

Could you please check if these need to be added?

@yu-croco
Copy link
Collaborator

yu-croco commented Jul 8, 2024

Hi @Fluder-Paradyne
I was planning to handle #2691 , but it's better to be handled in same PR. 🤔

@yu-croco
Copy link
Collaborator

yu-croco commented Jul 8, 2024

I added commit for git.commit-signing-key and git.commit-signing-method in 3fdb28e 🙋

@@ -31,6 +31,12 @@ data:
git.commit-message-template: |
{{- nindent 4 . }}
{{- end }}
{{- with .Values.config.gitCommitSigningKey }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also need somthing like config.gitConfigSigningMethod?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahhhh you are right 😇

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed in e64396a . 🙋

@mbevc1 mbevc1 merged commit ea28da2 into main Jul 9, 2024
6 checks passed
@mbevc1 mbevc1 deleted the renovate/argoproj-labs-argocd-image-updater-0.x branch July 9, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants