-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#119] doc: add details on the OpenShift setup #120
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaohoward
reviewed
Apr 10, 2024
RoddieKieley
previously approved these changes
May 6, 2024
RoddieKieley
previously approved these changes
May 17, 2024
9618725
to
af2b734
Compare
Msarawan
reviewed
Jun 25, 2024
gaohoward
requested changes
Jun 25, 2024
I have update the PR, I removed some of the changes that were not linked to the OpenShift setup in order to clarify the contribution. |
gaohoward
approved these changes
Jun 25, 2024
Msarawan
reviewed
Jun 25, 2024
Msarawan
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!
Add details on the documentation about setting up an OpenShift cluster and how to deploy the operator on it. These two steps being requirements for running the plugin successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add details on the documentation about setting up an OpenShift cluster and how to deploy the operator on it. These two steps being requirements for running the plugin successfully.