[#193] update the configuration to match the console template #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A possible followup for this PR: update patternfly to version 5 |
lavocatt
changed the title
lavocatt
force-pushed
the
versionupdate
branch
2 times, most recently
from
9620274
to
4f08dd0
Compare
There's no more v5 react-router deployed with the latest versions of the dynamic plugin sdk. Updating is mandatory.
From https://github.com/openshift/console-plugin-template at commit 2b4dbe4b4313e258be1754815614cf7d47f45c11 The latest patternfly4 compatible versions where recovered from: https://github.com/openshift/console/blob/649af93d7cb60e7cd9007c4a9a69ef74ec791680/frontend/package.json#L141 The package.json got sorted with npx sort-package-json for easier comparisons. Hack: For some reason, there's something strange happening with victory-core. If we remove this old configuration from the package.json file: ``` "resolutions": { "victory-core": "<36.9.0" }, "overrides": { "victory-core": "<36.9.0" }, ``` Then there are crashes running the metrics test suite (at the patternfly level). If we put it back, the UI won't render the metrics anymore. What is more surprising is that putting this section back, running yarn, removing it and running yarn once again **fixes both issues**. That's the reason why I'm leaving that piece of documentation in the commit, in case we need it back at some point. What we most probably need to do is to upgrade ASAP to patternfly 5.
Msarawan
reviewed
Jul 11, 2024
Msarawan
reviewed
Jul 11, 2024
Msarawan
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration got imported from https://github.com/openshift/console-plugin-template at commit
2b4dbe4b4313e258be1754815614cf7d47f45c11
The latest patternfly4 compatible versions where recovered from:
https://github.com/openshift/console/blob/649af93d7cb60e7cd9007c4a9a69ef74ec791680/frontend/package.json#L141
The package.json got sorted with npx sort-package-json for easier
comparisons.
Hack:
For some reason, there's something strange happening with victory-core.
If we remove this old configuration from the package.json file:
Then there are crashes running the metrics test suite (at the patternfly
level). If we put it back, the UI won't render the metrics anymore.
What is more surprising is that putting this section back, running yarn,
removing it and running yarn once again fixes both issues. That's
the reason why I'm leaving that piece of documentation in the commit, in
case we need it back at some point.
What we most probably need to do is to upgrade ASAP to patternfly 5.
Fixes #193