Don't start PyTorch thread just doing import. #516
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following modules:
easyocr
sentence_transformers
transformers
torchvision
all pull some shennanigans with
__init__.py
whereby the mere act of importing them starts a PyTorch thread. Aside from being rude, this has the side effect of attaching to the GPU and holding a reference count on the GPU devices in/dev/
. In a Ray context, we don't want the driver to use the GPU, just the workers. Also, just generally, importing something should not be so heavy-handed.