Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #240

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Fix typos #240

merged 1 commit into from
Jul 20, 2023

Conversation

jessp01
Copy link

@jessp01 jessp01 commented Jul 8, 2023

Great project. This pull fixes some minor README typos.

PS
I was pondering extending the solution so that you could overlay video bits over the div of the ASCIInema player so one can toggle between views (the text from the cast file and video segments). This will provide the ultimate solution to tutorials that require both shell work and screen display - GUI IDE, browser, whatnot). I was wondering whether this was previously considered/worked on?

Cheers,

@ku1ik
Copy link
Contributor

ku1ik commented Jul 20, 2023

Thanks!

Re overlaying video: that's not planned, not really in scope of this project. Interesting idea though. I think best would be to build some higher level component which would embed both asciinema player and the video element, and switch between them.

@ku1ik ku1ik merged commit c466528 into asciinema:develop Jul 20, 2023
@jessp01
Copy link
Author

jessp01 commented Jul 20, 2023

Hi @sickill ,

Yes, I agree. I'll give it a go and share the results with you. May I also ask, have you considered adding search functionality to asciinema-server? I think it would greatly help with discovering content. Another thought I had is adding the number of views to the cast previews.

@ku1ik
Copy link
Contributor

ku1ik commented Jul 26, 2023

Full-text search is definitely something I plan to add, just haven't gotten to it yet.

And displaying number of views on preview cards is excellent idea 👌

@jessp01
Copy link
Author

jessp01 commented Jul 26, 2023

I'll try to allocate some time to help with these:)
Also, I submitted this pull request: cookpete/react-player#1653

ReactPlayer is used in many different projects/platforms so supporting asciinema will hopefully help to increase adoption.

@ku1ik
Copy link
Contributor

ku1ik commented Jul 26, 2023

Oh, nice. Haven't heard about ReactPlayer but it seems cool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants