remove unused _warn_tag_mismatch and _warned_tag_pairs
#1786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
force-pushed
the
warn_tag_mismatch
branch
from
7e9db33
to
b859784
Compare
|
The weldx failure is unrelated and due to numpy 2.0. |
zacharyburnett
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are unused as seen in the coverage (and searching the asdf and downstream code):
https://app.codecov.io/gh/asdf-format/asdf/blob/main/asdf%2F_asdf.py#L1600
and appear to be related to the removed
TypeIndexand could have been removed in: #1637Checklist: