Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set strategy to ddp in ddp config #571

Merged
merged 1 commit into from
May 2, 2023
Merged

Set strategy to ddp in ddp config #571

merged 1 commit into from
May 2, 2023

Conversation

ashleve
Copy link
Owner

@ashleve ashleve commented May 2, 2023 •
edited
Loading

What does this PR do?

Previously strategy was set to ddp_spawn due to problems with normal ddp (#393).

Now the issue seems to be fixed in lightning

Before submitting

  • Did you make sure title is self-explanatory and the description concisely explains the PR?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you test your PR locally with pytest command?
  • Did you run pre-commit hooks with pre-commit run -a command?

Did you have fun?

Make sure you had fun coding 🙃

@ashleve ashleve added the bug Something isn't working label May 2, 2023
@ashleve ashleve mentioned this pull request May 2, 2023
Closed
@ashleve ashleve merged commit 1bffe79 into dev May 2, 2023
@ashleve ashleve deleted the fix-ddp-trainers branch May 2, 2023 19:42
@ashleve ashleve mentioned this pull request May 12, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@ashleve