Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reattach videooutput on too many failures #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davibe
Copy link

@davibe davibe commented Oct 17, 2017

I verified that sometimes AVPlayerItemVideoOutput may become stuck due to
broken media, strange network behaviours, or when media ends and the
user skips back to a valid position. This can result in

  • no video rendering
  • crashes (xcode sees the device as disconnected, no stack trace)

When this happens the video output needs to be recreated and reattached
ref. https://stackoverflow.com/questions/24800742/iosavplayeritemvideooutput-hasnewpixelbufferforitemtime-doesnt-work-correctly

This relates to #78 as it fixes some of the crashes i experienced. Not sure it fixes all of them, I am still testing

I verified that sometimes AVPlayerItemVideoOutput may become stuck due to
broken media, strange network behaviours, or when media ends and the
user skips back to a valid position. This can result in
- no video rendering
- crashes (xcode sees the device as disconnected, no stack trace)

When this happens the video output needs to be recreated and reattached
ref. https://stackoverflow.com/questions/24800742/iosavplayeritemvideooutput-hasnewpixelbufferforitemtime-doesnt-work-correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant